version: do not append 0-hash to version strings from a clean tag
#82
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My concern with this is that we use the same version script in all the repos, and that defines Docker image's tags etc, so I'm not against the change, but I think we should coordinate it globally so the "experience" across all repos is homogeneous. |
|
@ka3de Should we try it here first and see if we like it, or causes any problem? |
ka3de
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
versionscript would always append-0-hash, even when on a clean tag. For example:After this change, if run on a tagged commit without changes w.r.t. the tag, the output will just be the tag name:
This short name should be sufficiently descriptive, and more semver-compliant.